check number of active cells in shared::Tria #5362
Conversation
|
note: tests are still running here. |
| AssertThrowMPI(ierr); | ||
|
|
||
| const unsigned int total_cells | ||
| = Utilities::MPI::sum(n_my_cells, this->get_communicator()); |
There was a problem hiding this comment.
It seems a bit risky to me to use an unsigned int here for the global number of cells. Would you mind switching to std::size_t?
There was a problem hiding this comment.
It's a shared triangulation, so the sum of the number of locally owned cells (n_my_cells) adds up to the number of active cells each processor stores itself locally. I think it's unlikely that we're ever going to have machines where a single MPI process will store more than 4B cells :-)
There was a problem hiding this comment.
Note that the type of n_active_cells is an unsigned int and is equal to total_cells.
There was a problem hiding this comment.
good point; I forgot that all cells are stored locally in this case.
|
OK to merge once the tester is happy. /run-tests |
|
all shared tests run correctly here (unsurprisingly) |
source/distributed/shared_tria.cc
Outdated
| = Utilities::MPI::max(this->n_active_cells(), this->get_communicator()); | ||
| Assert(max_active_cells == this->n_active_cells(), | ||
| ExcMessage("A shared::Triangulation needs to be refined in the same " | ||
| "way on all processors, but there are currently a different " |
There was a problem hiding this comment.
The phrasing sounds (grammatically) wrong. Maybe
[...], but the participating processors don't agree on the number of active cells.
or
[...], but there are currently different numbers of active cells on the participating processors.
There was a problem hiding this comment.
I am also fine if you fix this up in a subsequent PR if you prefer that.
source/distributed/shared_tria.cc
Outdated
| const unsigned int max_active_cells | ||
| = Utilities::MPI::max(this->n_active_cells(), this->get_communicator()); | ||
| Assert(max_active_cells == this->n_active_cells(), | ||
| ExcMessage("A shared::Triangulation needs to be refined in the same " |
There was a problem hiding this comment.
this should be parallel::shared::Triangulation
tjhei
force-pushed
the
shared_check_same
branch
from
29cff3e
to
1fa75f4
Compare
|
updated. |
part of #5359