New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change sharedtria dof distribution to match distributed tria #5436
Conversation
/run-tests |
@@ -0,0 +1,14 @@ | |||
|
|||
{[0,20]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to put p4est into the filename
For the record: |
Yes. I was thinking about this yesterday. Those functions can go away. I will make a PR that deprecates them. |
This would deserve a changelog entry in the "incompatibilities" section. |
I'm a bit curious as to why the checks actually passed considering I have not yet fixed the test which fail to pass on my computer due to the change. Looking at the build details it doesn't appear to have run any sharedtria tests. I just still go back and update these, correct? |
Yes, you need to update these anyway. The tester only runs a subset of the sequential tests because running the entire test suite would take too long. |
8d4c674
to
562e56c
Compare
let us know when you check locally that all relevant tests pass with this PR. I put a WIP tag for now... |
562e56c
to
2f898bb
Compare
All tests for sharedtria now pass. |
2f898bb
to
88ba486
Compare
I've added the changelog entry and all relevant test have passed. Let me know if there are any other changes needed, if not everything should be good to go. Thanks! |
@tjhei @davydden @kronbichler Can this be merged? |
I have no further comments, ok to merge as far as I am concerned. |
I will go ahead and press "merge" then. |
This was discussed here: #3078 (comment)
Talking with @tjhei, we felt it best to change from "coin flip" assignment to "smallest subdomain" assignment for those active dofs on the interface between two subdomains of a
p::shared::T
so that we match the distribution inp::distributed::T
(this is also how we chose to distribute mg dofs forp::shared::T
).Note:
n_locally_owned_dofs
. This value will obviously change when we change the way in which we break ties along the interface.p::distributed::T
and ii) creating an adaptive mesh and outputting the owned dofs for each subdomain and dof numbering for each cell.