Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving and fixing GridTools::compute_point_locations #5468

Merged
merged 1 commit into from Nov 20, 2017

Conversation

GivAlz
Copy link
Contributor

@GivAlz GivAlz commented Nov 15, 2017

Hi everyone,
yesterday I had an idea on the algorithm for compute point locations. I think @tjhei will like it better, since it's the simpler one with his suggestion...but which has been then hybridized with the "use distance to avoid distant points" idea.
This has several benefits:

Moreover I tried to improve the documentation and removed the old distance factor altogether :)
Best,
Giovanni

@masterleinad
Copy link
Member

/run-tests

@masterleinad
Copy link
Member

Again, the failing test

	545 - all-headers/base/polynomial.h.debug (Timeout)
	546 - all-headers/base/polynomials_rannacher_turek.h.debug (Timeout)
	547 - all-headers/base/graph_coloring.h.debug (Timeout)
	548 - all-headers/base/job_identifier.h.debug (Timeout)
	549 - all-headers/base/vector_slice.h.debug (Timeout)
	550 - all-headers/base/data_out_base.h.debug (Timeout)
	551 - all-headers/base/function_spherical.h.debug (Timeout)

are very likely unrelated.

@GivAlz
Copy link
Contributor Author

GivAlz commented Nov 16, 2017

Yes, these tests are most definitely not related and, in fact, they failed because of "timeout", not of wrong output...my worry was for the other PR since fefieldfunction::compute_point_locations is used by other functions and some tests related to fe field functions are failing...but for this PR I think everything is fine so I believe it can be merged.

Thank you,
Giovanni

@luca-heltai luca-heltai merged commit ca6ed5c into dealii:master Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants