Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test serialization of hp::DoFHandler #5496

Merged
merged 1 commit into from Nov 28, 2017
Merged

Test serialization of hp::DoFHandler #5496

merged 1 commit into from Nov 28, 2017

Conversation

masterleinad
Copy link
Member

Fixes #4684.

@bangerth
Copy link
Member

All sorts of errors - it may simply be the time of day for you to actually sleep ;-)

/run-tests

@davydden davydden added the DoFs label Nov 18, 2017
jppelteret
jppelteret reviewed Nov 18, 2017
View reviewed changes
include/deal.II/hp/dof_handler.h Outdated
// some versions of gcc have trouble with loading vectors of
// std::unique_ptr objects because std::unique_ptr does not
// have a copy constructor. do it one level at a time
unsigned int n_levels = levels.size();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const unsigned int n_levels ?

include/deal.II/hp/dof_handler.h Outdated
// have a copy constructor. do it one level at a time
unsigned int n_levels = levels.size();
ar &n_levels;
for (unsigned int i = 0; i < levels.size(); ++i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< n_levels

include/deal.II/hp/dof_handler.h Outdated
ar &has_children;

// the same issue as above
unsigned int n_has_children = has_children.size();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsigned int n_has_children ?

include/deal.II/hp/dof_handler.h Outdated
// the same issue as above
unsigned int n_has_children = has_children.size();
ar &n_has_children;
for (unsigned int i = 0; i < has_children.size(); ++i)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

< n_has_children

@masterleinad masterleinad force-pushed the serialize_hp_dof_handler_test branch 2 times, most recently from c358f5a to 02b32ed Compare November 18, 2017 09:56
@masterleinad
Copy link
Member Author

All sorts of errors - it may simply be the time of day for you to actually sleep ;-)

Hey, it was just the indentation and the randomly failing timeouts on the testing machine. But fair enough, sleep is always helpful. 😃

@masterleinad
Copy link
Member Author

Again, only header timeouts:

	484 - all-headers/base/bounding_box.h.debug (Timeout)
	485 - all-headers/base/tensor_product_polynomials.h.debug (Timeout)
	486 - all-headers/base/function.templates.h.debug (Timeout)

@masterleinad
Copy link
Member Author

Is there anything I should address?

@masterleinad
Copy link
Member Author

It turned out that we had the same issue with clang-5.0.0 as for DoFHandler. This should be fine now.

@bangerth bangerth merged commit 07859c5 into dealii:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jppelteret jppelteret jppelteret left review comments

Assignees
No one assigned
Labels
DoFs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @bangerth @jppelteret @davydden