Fix treatment of periodic faces in communicate_locally_moved_vertices #5612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
Rombur
approved these changes
Dec 13, 2017
source/distributed/tria.cc
Outdated
| @@ -3064,23 +3064,11 @@ namespace parallel | |||
| } | |||
| #endif | |||
|
|
|||
| std::map<unsigned int, std::set<dealii::types::subdomain_id> > | |||
| vertices_with_ghost_neighbors; | |||
|
|
|||
| // First find out which process should receive which vertices. | |||
| // these are specifically the ones that sit on ghost cells and, | |||
| // among these, the ones that we own locally | |||
There was a problem hiding this comment.
I extended this comment a bit.
masterleinad
force-pushed
the
fix_periodic_moved_vertices
branch
from
79e4f57
to
88e4930
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in https://groups.google.com/forum/#!topic/dealii/9Imcfrpu7r4, we previously were forgetting about updating vertices across periodic boundaries in
parallel::distributed::communicate_locally_moved_vertices.In fact, it turned out that all the logic to construct
vertices_with_ghost_neighborswas already (correctly) implemented incompute_vertices_with_ghost_neighbors