Remove argument names when using '= default'. #5916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC 4.9 complains about this.
bangerth
reviewed
Feb 16, 2018
| @@ -200,13 +200,13 @@ class VectorMemory : public Subscriptor | |||
| * Move constructor: this creates a new Pointer by stealing the internal | |||
| * data owned by @p p. | |||
| */ | |||
| Pointer(Pointer &&p) = default; | |||
| Pointer(Pointer &&) = default; | |||
There was a problem hiding this comment.
I've long been bothered by this warning, but the problem is that if you remove the name, you can't refer to it in the documentation above any more :-(
|
Thats a good point. I don't see this error with newer releases of GCC so lets just skip this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCC 4.9 complains about this.