Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scalapack: split _06 test into four #5921

Merged
merged 3 commits into from
Feb 23, 2018
Merged

scalapack: split _06 test into four #5921

merged 3 commits into from
Feb 23, 2018

Conversation

davydden
Copy link
Contributor

@davydden davydden commented Feb 17, 2018 •
edited

also clean up a bit.

WIP until I check it on Linux as the last two parts 06b/06_c fail on macOS, that's the reason why I split the test into four parts to see where exactly it fails.

200 32 1 1
comparing 5 eigenvalues computed using LAPACK and ScaLAPACK pdsyevx:
   with respect to the given tolerance the eigenvalues coincide
[MBP-Denis:60680] *** Process received signal ***
[MBP-Denis:60680] Signal: Segmentation fault: 11 (11)
[MBP-Denis:60680] Signal code: Address not mapped (1)
[MBP-Denis:60680] Failing at address: 0x30
[MBP-Denis:60680] [ 0] 0   libsystem_platform.dylib            0x00007fff64212f5a _sigtramp + 26
[MBP-Denis:60680] [ 1] 0   libsystem_c.dylib                   0x00007fff9cc970f0 __c_locale + 0
[MBP-Denis:60680] [ 2] 0   libmpi.40.dylib                     0x0000000108fbb9c3 ompi_comm_destruct + 67
[MBP-Denis:60680] [ 3] 0   libmpi.40.dylib                     0x0000000108fbd255 ompi_comm_free + 357
[MBP-Denis:60680] [ 4] 0   libmpi.40.dylib                     0x0000000108ff1162 MPI_Comm_free + 178
[MBP-Denis:60680] [ 5] 0   libscalapack.dylib                  0x000000010894e4d9 Cblacs_gridexit + 153
[MBP-Denis:60680] [ 6] 0   libdeal_II.g.9.0.0-pre.dylib        0x000000011259f0c7 _ZN6dealii9Utilities3MPI11ProcessGridD2Ev + 23
[MBP-Denis:60680] [ 7] 0   libc++.1.dylib                      0x00007fff61ffc8fd _ZNSt3__119__shared_weak_count16__release_sharedEv + 43
[MBP-Denis:60680] [ 8] 0   scalapack_06c.debug                 0x00000001071a424f _Z4testIdEvjjT_ + 1727
[MBP-Denis:60680] [ 9] 0   scalapack_06c.debug                 0x00000001071a3b16 main + 230
[MBP-Denis:60680] [10] 0   libdyld.dylib                       0x00007fff63f91115 start + 1
[MBP-Denis:60680] *** End of error message ***
-------------------------------------------------------
Primary job  terminated normally, but 1 process returned
a non-zero exit code. Per user-direction, the job has been aborted.
-------------------------------------------------------
--------------------------------------------------------------------------
mpiexec noticed that process rank 0 with PID 0 on node MBP-Denis exited on signal 11 (Segmentation fault: 11).

davydden
davydden commented Feb 17, 2018
View reviewed changes
tests/scalapack/scalapack_06.cc
pcout << " with respect to the given tolerance the eigenvalues coincide" << std::endl;

for (unsigned int i=0; i<max_n_eigenvalues; ++i)
for (unsigned int j=0; j<size; ++j)
p_eigenvectors_[i][j] = p_eigenvectors(j,max_n_eigenvalues-1-i);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here git is confused, it's line 104-106 in the original version that stays.

@davydden
Copy link
Contributor Author

/run-tests

@davydden davydden changed the title scalapack: split _06 test into two scalapack: split _06 test into four Feb 18, 2018
@davydden
Copy link
Contributor Author

@BenBrands the last commit here should fix a minor bug in sizes of auxiliary arrays.

BenBrands
BenBrands reviewed Feb 19, 2018
View reviewed changes
source/lac/scalapack.cc Outdated
@@ -546,16 +547,15 @@ ScaLAPACKMatrix<NumberType>::eigenpairs_symmetric(const bool compute_eigenvector
* for jobz==N only eigenvalues are computed, for jobz='V' also the eigenvectors of the matrix are computed
*/
char jobz = compute_eigenvectors ? 'V' : 'N';
char range;
char range='Z';
Copy link
Contributor

@BenBrands BenBrands Feb 19, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put 'A' as default for range. Or is there a specific reason for choosing 'Z'?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's just something for it to be initialized in case it's forgotten to be so down there

@davydden davydden removed the WIP label Feb 19, 2018
@davydden
Copy link
Contributor Author

@dealii/dealii anyone objects merging this?

Rombur
Rombur reviewed Feb 23, 2018
View reviewed changes
tests/scalapack/scalapack_06b.cc
}
pcout << " with respect to the given tolerance the eigenvalues coincide" << std::endl;

// FIXME: run-time error on macOS if code between "pcout << comparing" and this line is executed.
Copy link
Member

@Rombur Rombur Feb 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean that we can't run this test on mac?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, i will investigate further later

Copy link
Contributor Author

@davydden davydden Feb 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be some bug in netlib-scalapack as it works in double precision and also works on all testers so far.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still want to merge this? It won't break the tester?

Copy link
Contributor Author

@davydden davydden Feb 23, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we do, as I said the current state it works for all testers. This PR only splits the test into several parts, as the title suggests

split _06 test into four

@Rombur Rombur merged commit 2d2a8c1 into dealii:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur left review comments

@BenBrands BenBrands BenBrands left review comments

Assignees
No one assigned
Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davydden @Rombur @BenBrands