Fix the memory usage of the /source/fe unity files. #5925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
Rombur
approved these changes
Feb 20, 2018
This is crazy because it shouldn't do anything useful, but I have seen similar effects as well. gcc seems to be particularly bad when it comes to the internal representation of long nested symbol lists that appear for heavily templated code - when compared to clang for example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes, such as b15febd, 36b74d6, and fd1bf6a caused the memory usage of one of the unity files to go above 5 GB: these splits lower the high water mark to about 3 GB.
I suspect
make_sharedis the culprit here: GCC's version is a huge memory hog.