Fix the location of hats on symbols in the documentation. #5933
Conversation
|
For the record, @sophy1029 is one of the students in my class. I'd appreciate if someone else could take a look. |
|
Did you use a different email address in the commit and the github user account to create the PR? Let me know if you want to fix that before we merge the PR. |
|
Yes. I prefer to use this email address, zhrwang@rams.colostate.edu
I will change that in my account.
Thanks.
…On Tue, Feb 20, 2018 at 1:02 PM, Timo Heister ***@***.***> wrote:
Did you use a different email address in the commit and the github user
account to create the PR? Let me know if you want to fix that before we
merge the PR.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5933 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AdMXNwyLeos5Dwm6S9h_ZAUtwKxlSsf4ks5tWyOWgaJpZM4SMM0F>
.
|
|
Thanks for the contribution @sophy1029! Out of curiosity, which browser are you viewing the documentation with? I looked at the Safari Firefox |
|
I'm using Safari on mac.
…On Tue, Feb 20, 2018 at 1:37 PM, Jean-Paul Pelteret < ***@***.***> wrote:
Thanks for the contribution @sophy1029 <https://github.com/sophy1029>!
Out of curiosity, which browser are you viewing the documentation with? I
looked at the 8.5.0's documentation with 2 browsers and it renders fine
on the one but not the other. But if this fixes the problem case then
that'd be great!
*Safari*
[image: step-50-safari]
<https://user-images.githubusercontent.com/10460610/36447837-d8c22320-1685-11e8-9f64-f96fd4d56499.png>
*Firefox*
[image: step-50-firefox]
<https://user-images.githubusercontent.com/10460610/36447838-d8de01f8-1685-11e8-8801-6f0ec4beb15b.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5933 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AdMXN6zrz12nX4292LKIr-GvmMHoLGkCks5tWy0FgaJpZM4SMM0F>
.
|
|
Ah, so its the same for both of us then. I also checked this on Chrome and it looks fine. Lets apply your patch and see if it has the desired effect! |
|
Congratulations on your first contribution to deal.II :-) We hope that it'll be the first of many! |
|
By the way, this is the place where the updated documentation will show up: @sophy1029 -- can you check tomorrow whether the issue is fixed on your browser, at least for the two places that you modified? |
|
Yes. Thanks!
…On Tue, Feb 20, 2018 at 2:36 PM, Wolfgang Bangerth ***@***.*** > wrote:
By the way, this is the place where the updated documentation will show up:
http://www.dealii.org/developer/doxygen/deal.II/step_51.html#
HybridizablediscontinuousGalerkinmethods
@sophy1029 <https://github.com/sophy1029> -- can you check tomorrow
whether the issue is fixed on your browser, at least for the two places
that you modified?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5933 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AdMXN1EOclXMCETy_vecBNnbk9yUPBxfks5tWzrWgaJpZM4SMM0F>
.
|
|
It still doesn't work on Safari. But it looks fine on Chrome on Mac. |
|
Ah, that's too bad. That's then a bug in Safari, I'm afraid. There isn't anything we can do about it, but thanks for trying! |
In the MathML generated documentation of step-51, there are a number of hats that are misplaced. See for example http://www.dealii.org/8.5.0/doxygen/deal.II/step_51.html#HybridizablediscontinuousGalerkinmethods
This looks correct in latex, but apparently comes out wrong on the website. This patch is a trial with the first two occurrences so we can see if placing another set of braces helps the problem.