Use more LAPACK and BLAS routines in LAPACKFullMatrix #5934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davydden
reviewed
Feb 20, 2018
|
|
||
| // Multiply rectangular mxn real matrix by real scalar CTO/CFROM | ||
| void dlascl_(const char *type, | ||
| const int *kl, |
There was a problem hiding this comment.
Please use dealii::types::blas_int
source/lac/lapack_full_matrix.cc
Outdated
|
|
||
| lascl(&type,&kl,&kl,&factor,&cto,&m,&n,values,&lda,&info); | ||
|
|
||
| Assert(info >= 0, ExcInternalError()); |
There was a problem hiding this comment.
I think we throw some custom error for Lapack
source/lac/lapack_full_matrix.cc
Outdated
| for (size_type i=0; i<m(); ++i) | ||
| for (size_type j=0; j<n(); ++j) | ||
| (*this)(i,j) += a * A(i,j); | ||
| // BLAS does not offer functions to add matrices |
BenBrands
force-pushed
the
LapackFullMatrix
branch
2 times, most recently
from
99f399f
to
efab33b
Compare
BenBrands
force-pushed
the
LapackFullMatrix
branch
from
efab33b
to
453f4e2
Compare
Rombur
approved these changes
Feb 20, 2018
|
/run-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a partial remedy to #5900.
The assignment operator for
FullMatrixis not changed due to the different memory layouts ofFullMatrixandLAPACKFullMatrix.