Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure is_contiguous() compares addresses, not values, of array objects. #6123

Merged
merged 2 commits into from Mar 30, 2018
Merged

Make sure is_contiguous() compares addresses, not values, of array objects. #6123

merged 2 commits into from Mar 30, 2018

Conversation

bangerth
Copy link
Member

This fixes #6121. It doesn't need a changelog entry since the function is new anyway.

masterleinad
masterleinad approved these changes Mar 29, 2018
View reviewed changes
Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bangerth
Copy link
Member Author

/run-tests

@jppelteret jppelteret merged commit 99d7586 into dealii:master Mar 30, 2018
@bangerth bangerth deleted the fix-is_contiguous branch March 30, 2018 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@davydden davydden davydden approved these changes

Assignees
No one assigned
Labels
Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question about is_contiguous() when creating an ArrayView
4 participants
@bangerth @masterleinad @davydden @jppelteret