Provide better documentation to p::d::Triangulation::register_data_attach(). #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcfehling -- FYI. |
|
/run-tests |
|
Ping? |
kronbichler
approved these changes
Apr 16, 2018
include/deal.II/distributed/tria.h
Outdated
| * may land. | ||
| * - `CELL_REFINE`: this cell will be refined into 4 or 8 cells (in 2d | ||
| * and 3d, respectively). However, because these children don't exist | ||
| * yet, you cannot access them yet at the time when the callback is |
There was a problem hiding this comment.
remove the second 'yet' (?)
|
@kronbichler -- I fixed the grammar issue. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there, also cleanup the code a tiny bit.
This is a first step to document the issue in #6223 a bit better. I think I'll
have to do a similar thing in notify_ready_to_unpack() as well, but that will
have to wait for a separate PR. One step at a time.