Refer to FESystem as such (not FE_System). #7138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes some doxygen links.
bangerth
approved these changes
Sep 1, 2018
bangerth
reviewed
Sep 1, 2018
| @@ -1994,7 +1994,7 @@ FESystem<dim, spacedim>::get_subface_interpolation_matrix( | |||
| FullMatrix<double> & interpolation_matrix) const | |||
| { | |||
| AssertThrow( | |||
| (x_source_fe.get_name().find("FE_System<") == 0) || | |||
| (x_source_fe.get_name().find("FESystem<") == 0) || | |||
There was a problem hiding this comment.
Oy, how did this work? What does FESystem's get_name() function return?
There was a problem hiding this comment.
It returns the correct value. We are saved by the dynamic cast on the next line :)
|
/run-tests |
kronbichler
reviewed
Sep 1, 2018
| @@ -534,7 +534,7 @@ class MatrixFree : public Subscriptor | |||
| * pointers to the initialization function. Note that the finite element | |||
| * underlying an DoFHandler must either be scalar or contain several copies | |||
| * of the same element. Mixing several different elements into one | |||
| * @p FE_System is not allowed. | |||
| * FESystem is not allowed. | |||
There was a problem hiding this comment.
I realize that this comment is outdated since #6300 or one of the related commits from #5667. Can you replace the part starting from Note that the finite element underlying... by the following text (I do not have the time right now to prepare it myself):
As an alternative, a system of several components can also be represented by a single
DoFHandler based on an FESystem. The prerequisite for this case is that each base element
of the FESystem must be compatible with the present class, such as the FE_Q or FE_DGQ
classes.
drwells
force-pushed
the
fix-FESystem-name
branch
from
369a922
to
1fdde1f
Compare
masterleinad
approved these changes
Sep 2, 2018
kronbichler
approved these changes
Sep 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some doxygen links.