Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the MatrixFree doxygen formatting #7167

Merged
merged 1 commit into from Sep 14, 2018

Conversation

drwells
Copy link
Member

@drwells drwells commented Sep 8, 2018

This is a followup to #7129: I added name qualifications and a few other minor things to make it easier to read the matrix free module header.

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change internal::MatrixFreeFunctions::ElementType::tensor_symmetric_hermite to internal::MatrixFreeFunctions::tensor_symmetric_hermite in doc/doxygen/headers/matrixfree.h?

* DoFAccessor, respectively. Each group also has specialized accessors for
* cells (as opposed to faces and lines) that offer more functionality such as
* accessing neighbors.
* DoFHandler - hp::DoFHandler objects. They are derived from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks uncommon. Why do you want to use - instead of /?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the opposite: hyphens are for linking words together in prose. I don't think I have seen /s used to do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you're not connecting; you're enumerating. I think "/" is correct here.

(You'd use the dash in a sentence like "While the Vector-Matrix connection is clear, the Triangulation-DoFHandler connection is harder to understand.")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should get a style manual and read it. Wikipedia says that / can be used as a shorthand for 'and' so lets stick with / here; you're right.

@drwells
Copy link
Member Author

drwells commented Sep 13, 2018

I fixed the internal::MatrixFreeFunctions::tensor_symmetric_hermite link.

@@ -165,10 +165,10 @@ class TriaActiveIterator;
*
* The accessors provided by the library consists of two groups, determined by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while you're here, can you replace "consists" by "consist" to get the grammar right? Though maybe "fall" or "can be grouped into two classes" would actually be better

@kronbichler kronbichler merged commit f030188 into dealii:master Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants