Improve the message for 'make strip_comments'. #7194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
approved these changes
Sep 14, 2018
|
well, every change is possible with |
drwells
approved these changes
Sep 14, 2018
|
We don't have an 'unstrip' command, though, and resetting can be annoying, so lets go with it. Its annoying that we have to wait for Travis here... |
|
The point is not how to do that in a git tree, but in the installation directory where users execute tutorial programs. There is literally nothing automatic you can do to get the comments back short of copying the original over from the source tree again. |
|
Good point. I am too used to just running them straight in the tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is remarkable how often I find myself asked how one can get the
comments back after calling 'make strip_comments'. Document that one can't.