Fix PETSc version detection #7203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Sep 17, 2018
|
/run-tests |
|
Let's rebase and restart the tester. |
…e regexp as "0" and not "10")
masterleinad
force-pushed
the
master
branch
from
23f37e1
to
8a11953
Compare
tamiko
added a commit
to tamiko/dealii
that referenced
this pull request
Oct 1, 2018
Similarly to what was fixed in dealii#7203, fix the regex to also pick up two (or more digit) version numbers correctly.
This was referenced Oct 3, 2018
drwells
pushed a commit
to drwells/dealii
that referenced
this pull request
Oct 3, 2018
Similarly to what was fixed in dealii#7203, fix the regex to also pick up two (or more digit) version numbers correctly.
marcfehling
pushed a commit
to marcfehling/dealii
that referenced
this pull request
Oct 3, 2018
Similarly to what was fixed in dealii#7203, fix the regex to also pick up two (or more digit) version numbers correctly.
masterleinad
pushed a commit
to masterleinad/dealii
that referenced
this pull request
Oct 5, 2018
Similarly to what was fixed in dealii#7203, fix the regex to also pick up two (or more digit) version numbers correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
petsc version 3.10 works now too (minor version was found by the regexp as "0" and not "10")
regexps are greedy, i.e. you need to add an explicit whitespace, otherwise everything but the last digit will be matched by
.*betweenPETSC_VERSION_MINORand[0-9]+(the current git master of petsc defines PETSC_VERSION_MINOR to 10)