Remove DEAL_II_WITH_THREADS checks, revert #7246 #7250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We provided these in cases where someone wanted to not compile for multithreading, in which case certain functionality from the TBB was not available. But the implementations of these classes is now unconditionally available via the C++11 standard library, and so we don't need the dummy implementations any more.
This reverts commit 49e7b20.
|
/run-tests |
|
This supersedes #7249, so I'll close that one. But since @masterleinad and I collaborated on this, we both can't merge this. Or maybe I can state that I'm ok with his patches, and if he's ok with mine, then we can? |
tamiko
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #7249, this PR reverts #7246 and removes the
DEAL_II_WITH_THREADScheck in some more places. Tested to compile and pass the test suite withDEAL_II_WITH_THREADS=OFFand a minimal configuration.