Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the minimal supported MPI version #7680

Merged
merged 2 commits into from Feb 6, 2019

Conversation

masterleinad
Copy link
Member

Related to #7677. Looking at FindMPI.cmake it doesn't seem feasible to check for the MPI version being at least 2.0 since there seem to be cases where we fail to detect the correct version.

@drwells
Copy link
Member

drwells commented Feb 2, 2019

Are we actually compatible with MPI 2.0? I have no idea if we are using any newer features or not.

@masterleinad
Copy link
Member Author

All I can say is that we test for 2.2 in mpi.cc. Hence, I guess that someone tried build with something less than this at least at some point.

@masterleinad
Copy link
Member Author

For compiling with OpenMPI-1.2.9 (MPI-2.0) I needed some changes:

  • I could only find MPI_Comm_create_group used in ScaLAPACKMatrix::copy_from and ScaLAPACKMatrix::copy_to in the MPI-3.0 documentation. Hence, these function are declared as not implemented if the detected MPI version is less than 3.0.
  • MPI_Isend uses a non-const buffer before MPI-3.0. Hence, we need the DEAL_II_MPI_CONST_CAST macro in a couple more places.

@masterleinad
Copy link
Member Author

/rebuild

@tjhei tjhei merged commit ede87ca into dealii:master Feb 6, 2019
@masterleinad masterleinad deleted the document_MPI_minimal branch February 6, 2019 16:23
@drwells
Copy link
Member

drwells commented Feb 6, 2019

Thanks for checking (and digging up this ancient version of openmpi!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants