New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup the Vector::thread_loop_partitioner logic. #7683
Cleanup the Vector::thread_loop_partitioner logic. #7683
Conversation
/rebuild |
715ecb4
to
5fe0ed6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Is there anything in la_parallel_vector.h
that can/should be treated similarly?
We have a number of tests failing
with the error
|
All of those tests pass on my laptop :( I am investigating. |
@kronbichler I think that vector class is in better shape (it swaps partitioners correctly). I will take a closer look later. |
5fe0ed6
to
518cdef
Compare
I think I fixed the issues. |
It was previously possible to, in one function call, either set up the partitioner multiple times or for inappropriately small vectors. This commit cleans up the way we handle the partitioner in multiple places so that, when possible, vectors share partitioners and do not set up partitioners if they are too small.
518cdef
to
461fb77
Compare
This passes the test suite for me locally. Let's merge. |
It was previously possible to, in one function call, either set up the partitioner multiple times or for inappropriately small vectors. This commit cleans up the way we handle the partitioner in multiple places so that, when possible, vectors share partitioners and do not set up partitioners if they are too small.
Fixes #7646.