Patch for distribute_local_to_global #7726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Feb 14, 2019
There was a problem hiding this comment.
This looks good to me, thanks for the contribution. Could you please add a small file named doc/news/changes/minor/20190213SebastianStark where you describe the change in 1 or 2 sentences, in analogy to the other files you find in that folder? This makes your contribution appear on the list of changes to the current deal.II version.
Also, you should rebase your branch to master to get rid of the merge commits.
|
/rebuild |
sebastian-stark
force-pushed
the
fix_matrix_diagonals
branch
3 times, most recently
from
47bb4b6
to
23d0f0f
Compare
If a local matrix with all diagonal elements equal to zero is distributed to a global matrix, the l1 norm of the local matrix divided by the size of the local matrix is now added to those diagonal elements of the global matrix which correspond to a constrained dof. In case the entire local matrix is zero, 1 is added. Previously zero was added for both cases, possibly resulting in singular global matrices. Additionally, a test for the patched version of distribute_local_to_global has been added. Fixes dealii#7658
sebastian-stark
force-pushed
the
fix_matrix_diagonals
branch
from
23d0f0f
to
5cca395
Compare
masterleinad
approved these changes
Feb 14, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for #7658