Fix a mistaken assertion that only succeeds by accident. #7960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically, it succeeds because we get a pointer to the first of a block of elements where the size of the block is greater than one. If one had a 1-point quadrature formula, the assertion would fail.
|
This is about as minimal as it gets for patches :-) |
tamiko
approved these changes
Apr 24, 2019
|
I was thinking about whether I can suggest changes that triple, or quadruple the size of the changeset 😝 |
|
As long as you don't ask me to come up with a more concise, less verbose fix it's all good :-) |
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, it succeeds because we get a pointer to the first of a block of
elements where the size of the block is greater than one. If one had a 1-point
quadrature formula, the assertion would fail.
See also the discussion in https://github.com/dealii/dealii/pull/6747/files#r277197764
as part of #6747.