Fix compressing TrilinosWrappers::SparsityPattern with empty column map #8277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
kronbichler
reviewed
May 27, 2019
| @@ -791,7 +791,8 @@ namespace TrilinosWrappers | |||
| if (nonlocal_graph.get() != nullptr) | |||
| { | |||
| if (nonlocal_graph->IndicesAreGlobal() == false && | |||
| nonlocal_graph->RowMap().NumMyElements() > 0) | |||
| nonlocal_graph->RowMap().NumMyElements() > 0 && | |||
| column_space_map->NumMyElements() > 0) | |||
There was a problem hiding this comment.
Don't you want to check for column_space_map->NumGlobalElements() > 0? We have a switch for an empty column space map on the local process in line 811 below. See also #7833.
kronbichler
approved these changes
May 27, 2019
masterleinad
force-pushed
the
fix_trilinos_sp_empty_col_map
branch
from
3da8c3b
to
a888d8c
Compare
masterleinad
force-pushed
the
fix_trilinos_sp_empty_col_map
branch
from
a888d8c
to
c5ff9b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem in https://groups.google.com/forum/#!topic/dealii/Pb4xy7qcNW0
causes problems if we try to insert an entry that it is not contained in the row and column maps.
If the column map is empty, we consequently can't insert any dummy element at all.