Add maxwell equations tutorial #8345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangars
force-pushed
the
maxwell_tutorial
branch
from
fb2fc7b
to
cfeb22b
Compare
|
@dangars I hope you didn't close this PR because you couldn't get feedback for it. I apologize for not getting to patch reviews lately, in particular to the very large ones. I do hope that we get your program eventually! |
|
@bangerth Thanks for your message. I closed it because I have too many projects in parallel and had to prioritize. In France it is grant writing season. I also wanted to finish #8419 Which I finished today. It works and the test gives the expected result but I'm not sure I take the best approach, you can take a look ;) I'm going to give a final push to this PR and re-open it very soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo list: