Grid tools debug #8519
Grid tools debug #8519
Conversation
|
Please create two separate pull requests if you are fixing unrelated issues. Could you also add a test case that would fail prior to this pull request? |
|
And if you need help with anything @masterleinad said, talk to one of us! |
|
@mjayadharan -- come see me tomorrow and we'll fix the git issues. @dealii/dealii : There's no test that can check this. What was happening is that we wanted to cache things, but forgot to set the flag that we had already computed something. The result wasn't wrong -- it was just inefficient: Every time we were looking up the information we re-computed it. |
mjayadharan
force-pushed
the
grid_tools_debug
branch
from
aefcaff
to
d038f4a
Compare
|
I have separated two issues with this pull request. Now please take at look. |
|
/rebuild OK to merge if it passes the tester (which I strongly suspect it will). Thanks for the patch, @mjayadharan ! |
|
Fixes #8517. |
|
Glad that it worked out.
…On Mon, Aug 12, 2019 at 8:08 PM Wolfgang Bangerth ***@***.***> wrote:
/rebuild
OK to merge if it passes the tester (which I strongly suspect it will).
Thanks for the patch, @mjayadharan <https://github.com/mjayadharan> !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#8519?email_source=notifications&email_token=AIR5RWLG5UP52DD545ORIRDQEH3PZA5CNFSM4IKOQ3GKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4EFK6A#issuecomment-520639864>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIR5RWKZB2IQRAQYU5RVK73QEH3PZANCNFSM4IKOQ3GA>
.
|
|
Thanks for fixing my mistake! :) |
Fixes #8517.