Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement DoFAccessor::set/get_mg_dof_indices for 1D #8593

Merged
merged 1 commit into from Aug 18, 2019

Conversation

peterrum
Copy link
Member

@peterrum peterrum commented Aug 17, 2019

This PR is part of the effort to introduce the new parallel::fullydistributed::Triangulation (see #8558) and is a follow-up to PR #8592.

This PR implements DoFAccessor::set_mg_dof_indices and DoFAccessor::get_mg_dof_indices for 1D. We need this, since p:f:t works for 2D, 3D, and 1D(!) for GMG.

Note: Please only consider the last commit, since all other commits will be removed from this PR once PR #8592 is merged. I still have to add tests.

Ping: @bangerth @tjhei

@peterrum peterrum changed the title Implement DoFAccessor::set_mg_dof_indices and get_mg_dof_indices for 1D Implement DoFAccessor::set/get_mg_dof_indices for 1D Aug 17, 2019
@bangerth
Copy link
Member

The last commit is ok. If you do

  git checkout dofaccessor_mgdofindices_1D
  git rebase -i master

and then drop all of the commits except the last one, you will end up with a branch that has only this last commit on it. That's the one we want to review and merge. (And of course this has no influence on all of your other branches: They continue to contain all of the commits you had on there before!)

@peterrum
Copy link
Member Author

@bangerth I have updated all PRs so that each of them has exactly one PR.

@bangerth
Copy link
Member

Thanks, that is much better!

@masterleinad
Copy link
Member

/rebuild

@masterleinad masterleinad merged commit 79ed536 into dealii:master Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants