Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add failing p4est test #8603

Merged
merged 1 commit into from May 12, 2020
Merged

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Aug 19, 2019

This is a simple way to trigger #7428

@tjhei
Copy link
Member Author

tjhei commented Aug 19, 2019

(this should of course not be merged as is)

This is a simple way to trigger
dealii#7428
@tjhei
Copy link
Member Author

tjhei commented May 11, 2020

I changed the test to be expected=run, so we can merge it. @tamiko

@kronbichler kronbichler merged commit 01ba65a into dealii:master May 12, 2020
@kronbichler
Copy link
Member

I have one question about this test, since I see the release version failing here:
https://cdash.43-1.org/testDetails.php?test=44174832&build=6322
where failing means that the test does indeed run and not abort with an exception: Do we need the debug version of p4est here or is deal.II-debug enough? In the latter, we can append a .debug.output, but in the former I don't know immediately.

@bangerth
Copy link
Member

It's not clear what the point of having this in the testsuite is. We still need to find the bug and a way to work around it.

@tjhei
Copy link
Member Author

tjhei commented May 12, 2020

I have one question about this test, since I see the release version failing here:
https://cdash.43-1.org/testDetails.php?test=44174832&build=6322

The assert is only triggered in debug mode, yes. Let me make a fix.

@tjhei
Copy link
Member Author

tjhei commented May 12, 2020

It's not clear what the point of having this in the testsuite is. We still need to find the bug and a way to work around it.

We decided to include it during our zoom meeting yesterday. Maybe merging it in the last minute was not the best idea, but generally it is good to have so that the test a) gets ported forward and b) we will know if something changes due to changes inside p4est.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants