Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the description of the Nedelec element. #8869

Merged
merged 2 commits into from Oct 12, 2019

Conversation

bangerth
Copy link
Member

In the same spirit as #8844.

@dangars
Copy link
Contributor

dangars commented Sep 29, 2019

Very clear!

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only a small typo (copy-paste from the other PR on RT).

* @ref GlossPrimitive "not a primitive element"; (ii) the shape functions
* are defined so that certain integrals over the faces are either zero
* or one, rather than the common case of certain point values being
* either zero or one. (There is, however, the FE_RaviartThomasNodal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* either zero or one. (There is, however, the FE_RaviartThomasNodal
* either zero or one.

I think you do not want to refer to RT here - do we happen to have a nodal H^curl element to mention here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's really just a copy-paste error.

@bangerth
Copy link
Member Author

I fixed the one issue. @kronbichler .

@kronbichler kronbichler merged commit 8467ce4 into dealii:master Oct 12, 2019
@bangerth bangerth deleted the nedelec branch October 16, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants