-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEInterfaceValues: gradients and hessians #8885
Conversation
add average_gradient(), average_hessian(), jump_gradient()
/rebuild |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straight-forward. Any reason that there is no jump_hessian
(apart from that you don't need it yourself right now)?
Did you check the output of the test for correctness somehow?
I only implemented everything needed for fourth order problems (and tested it in an application).
It seems to work correctly in a separate application and the output here did not look incorrect, but I can think of a better test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks largely ok. Please make the minor modifications and merge yourself!
@@ -307,6 +307,47 @@ class FEInterfaceValues | |||
const unsigned int q_point, | |||
const unsigned int component = 0) const; | |||
|
|||
/** | |||
* Return the average of the gradient $\{\nabla u \} = \frac{1}{2}\nabla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we typically use double-braces for the jump?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the average not the jump and I used single braces in average()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough -- I guess I've seen it both ways.
add average_gradient(), average_hessian(), jump_gradient()
part of #8884