Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEInterfaceValues: gradients and hessians #8885

Merged
merged 2 commits into from
Oct 25, 2019

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Oct 2, 2019

add average_gradient(), average_hessian(), jump_gradient()

part of #8884

add average_gradient(), average_hessian(), jump_gradient()
@tjhei tjhei mentioned this pull request Oct 2, 2019
15 tasks
@tjhei
Copy link
Member Author

tjhei commented Oct 9, 2019

/rebuild

Copy link
Member

@masterleinad masterleinad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty straight-forward. Any reason that there is no jump_hessian (apart from that you don't need it yourself right now)?
Did you check the output of the test for correctness somehow?

@tjhei
Copy link
Member Author

tjhei commented Oct 10, 2019

Any reason that there is no jump_hessian (apart from that you don't need it yourself right now)?

I only implemented everything needed for fourth order problems (and tested it in an application).

Did you check the output of the test for correctness somehow?

It seems to work correctly in a separate application and the output here did not look incorrect, but I can think of a better test...

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks largely ok. Please make the minor modifications and merge yourself!

@@ -307,6 +307,47 @@ class FEInterfaceValues
const unsigned int q_point,
const unsigned int component = 0) const;

/**
* Return the average of the gradient $\{\nabla u \} = \frac{1}{2}\nabla
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we typically use double-braces for the jump?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the average not the jump and I used single braces in average()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough -- I guess I've seen it both ways.

include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
include/deal.II/fe/fe_interface_values.h Outdated Show resolved Hide resolved
include/deal.II/fe/fe_interface_values.h Show resolved Hide resolved
@bangerth bangerth merged commit 052e014 into dealii:master Oct 25, 2019
@tjhei tjhei deleted the fe_interface_values_3 branch October 25, 2019 07:29
@tjhei tjhei added this to Done in FEInterfaceValues Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants