Avoid variable template in hp::Refinement #9186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
approved these changes
Dec 21, 2019
|
/rebuild |
bangerth
reviewed
Dec 22, 2019
| ComparisonFunction<Number> compare_false = | ||
| [](const Number &, const Number &) { return false; }; | ||
| ComparisonFunction<Number> compare_true = | ||
| [](const Number &, const Number &) { return true; }; |
|
As a complete aside, it's not that the thing is a generic lambda (which would be a structure with a Either way, the change is of course correct -- thanks for tackling it! |
masterleinad
force-pushed
the
avoid_generic_lambda
branch
from
d79f601
to
0152465
Compare
|
Yes, you are right. |
masterleinad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing build in https://cdash.43-1.org/viewBuildError.php?onlydeltap&buildid=3370.
Generic lambdas are a C++14 feature.