Keep the 'dealii::' in 'using namespace dealii::'. #9209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of our example code on the website (e.g., step-40) doesn't work since we
get rid of the preceding dealii and print
using namespace ::LinearAlgebraPETSc;
when it should be
using namespace dealii::LinearAlgebraPETSc;
instead. This change keeps the 'dealii::' only in this case, which currently
only occurs in step-40.cc, step-50.cc, step-55.cc, and local_integrators.h.
|
This does prevent doxygen from correctly forming a link but I think its better to show the right code than to have the right link. |
bangerth
approved these changes
Jan 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our example code on the website (e.g., step-40) doesn't work since we get rid of the preceding
dealiiand printwhen it should be
instead. This change keeps the
dealii::only in this case, which currently only occurs in step-40.cc, step-50.cc, step-55.cc, and local_integrators.h.Fixes #9163.