Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: Check whether Trilinos has been configured with third-party libraries. #9266

Merged
merged 2 commits into from
Jan 10, 2020
Merged

CMake: Check whether Trilinos has been configured with third-party libraries. #9266

merged 2 commits into from
Jan 10, 2020

Conversation

marcfehling
Copy link
Member

@marcfehling marcfehling commented Jan 8, 2020 •
edited by tamiko

Not entirely sure whether this fixes #9252, since I don't know in which format Trilinos actually stores its third-party libraries, i.e. mumps|Mumps|MUMPS.

@BenBrands -- Would you be so kind and check whether the tests mpi/hp_step-4 show up in your ctest -N | grep "hp_step-4" after applying the update?

Fixes #9252

@BenBrands
Copy link
Contributor

No, after your modifications the tests hp_step-4 are not picked up by ctest.

@marcfehling
Copy link
Member Author

marcfehling commented Jan 9, 2020 •
edited

Just noticed that I introduced a typo :(
Would you try again? Hopefully this is it!

$ cmake
$ make setup_tests_mpi
$ ctest -N | grep "hp_step-4"

@BenBrands
Copy link
Contributor

It is working!

marcfehling
marcfehling commented Jan 9, 2020
View reviewed changes
Copy link
Member Author

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for trying out! Guess this PR is ready for review then.

cmake/configure/configure_2_trilinos.cmake Outdated Show resolved Hide resolved
tamiko
tamiko approved these changes Jan 9, 2020
View reviewed changes
Copy link
Member

@tamiko tamiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You even followed my crazy comment style :-D

@tamiko
Copy link
Member

tamiko commented Jan 9, 2020

/rebuild

@marcfehling
Copy link
Member Author

There may be issues with the memory space for some testers -- @tjhei

/jenkins/workspace/dealii_PR-9266/tests/fe/mass_matrix_arbitrary_nodes.cc:90:1: fatal error: error writing to /tmp/cctGcRue.s: No space left on device

@tamiko
Copy link
Member

tamiko commented Jan 10, 2020

Well, we configured correctly and that is what I wanted to se..

@tamiko tamiko merged commit a3f4f14 into dealii:master Jan 10, 2020
@marcfehling marcfehling deleted the fix-amesos branch January 10, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth left review comments

@tamiko tamiko tamiko approved these changes

Assignees
No one assigned
Labels
Build system ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test mpi/hp_step_4 fails because of missing Trilinos component
4 participants
@marcfehling @BenBrands @tamiko @bangerth