Convert step-30 from using eps/gnuplot to svg/vtu. #9493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've already put the figures on the website.
I wanted to double-check the mesh outputs but I probably don't have the permissions to view them. I don't know if that's intentional or not.
https://www.dealii.org/images/steps/developer/step-30.grid-0.aniso.9.1.png
Other than that everything looks great.
The figures as currently used are actually quite ugly. We can do substantially better. While there, also clean up the function that creates output a bit.
|
Ah, good check -- these file names should all have had "9.2" instead of "9.1" in the names. I've fixed the patch. Thanks! |
|
Ping? |
|
/rebuild |
kronbichler
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The figures as currently used are actually quite ugly. We can do
substantially better. While there, also clean up the
function that creates output a bit.
I've already put the figures on the website.
In reference to #5982.