Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change return type of DoFHandler::n_locally_owned_dofs() #9735

Merged

Conversation

peterrum
Copy link
Member

I would like to make the return type of this function consistent with the return type of hp::DoFHandler::n_locally_owned_dofs().

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree, this is in line with similar changes we have done recently in terms of 64 bit support (even though we do not really support more than 4b process-local dofs IIRC).

@kronbichler
Copy link
Member

/rebuild

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcfehling -- FYI

@@ -1023,7 +1023,7 @@ class DoFHandler : public Subscriptor
* cells owned by other processors may be theirs, and degrees of freedom on
* ghost cells are also not necessarily included.
*/
unsigned int
types::global_dof_index
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch -- probably not wrong, but definitely an oversight...

@bangerth bangerth merged commit 57d7484 into dealii:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants