Uniquely specify namespace #9737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine, but could you add a comment describing the problem to the first usage? |
bangerth
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
These are all in an internal file. Let's not worry about adding a comment -- it's not clear where it should be anyway, and it doesn't make sense to reproduce the same comment in all places where @gassmoeller is making the change.
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that only appears when trying to combine and collectively compile deal.II header files (like we do in ASPECT using cotire). Using the namespace
parallel::internalininclude/deal.II/lac/vector_operations_internal.hleads to errors of the form:namespace dealii::internal::parallel::internal not declaredwhen including the combined header (tested with gcc 9.2.1). Of course we are really looking for the namespacedealii::parallel::internalbut the namespace lookup gets confused. I suspect this is because there is a namespacedealii::internal::paralleldeclared indistributed/cell_data_transfer.templates.hand we are insidedealii::internalwhen starting this lookup, which is why the compiler ends up in the wrong namespace. This PR removes the compiler errors by fully referencing the namespace. I suspect this problem appeared before, because most other references in this file to this particular namespace already include the leading::dealii::.