New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GridTools/GridGenerator: add some functions to support dim-independent programming #9739
Conversation
The changes to rotate make sense but I'm not so sure about extrusion. What case did you find where we need an additional extrusion overload? |
I get this error message error: no matching function for call to extrude_triangulation(dealii::Triangulation<2, 2>&, unsigned int, const double&, dealii::Triangulation<2, 2>&) |
Sure, but what does the call site look like? |
something like this |
@drwells Did I answer your questions? Please let me know if I still misunderstood something. |
Sorry, I meant to get back to you on this. I think this is fine but we need to add documentation explaining the extrude is only available for 2D to 3D. |
I also think that it is a bit weird but it does help make user code much simpler without having to rely on |
/rebuild |
source/grid/grid_generator.cc
Outdated
@@ -6164,7 +6164,6 @@ namespace GridGenerator | |||
} | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this line back in? We typically tend to keep three empty lines between function implementations for readability, see here: https://dealii.org/developer/doxygen/deal.II/CodingConventions.html (style issues, no 4). Similarly also between the new function and the old one below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from the empty lines.
The functions
rotate()
andextrude_triangulation()
are currently only implemented for dim=2 or 3. This PR allows to write code that can be compiled for dim=2,3.