Explicitly spell dealii::parallel in multiple places #9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
reviewed
Mar 28, 2020
There was a problem hiding this comment.
While the change looks generally ok to me, I wonder which namespace was creating the conflict for you (because it makes argument lists quite long, especially in dof_handler_policy.cc) - is it internal::parallel::distributedGridRefinement or do we have many others?
include/deal.II/grid/tria.h
Outdated
| @@ -3916,7 +3916,7 @@ class Triangulation : public Subscriptor | |||
|
|
|||
| friend struct dealii::internal::TriaAccessorImplementation::Implementation; | |||
|
|
|||
| friend class hp::DoFHandler<dim, spacedim>; | |||
| friend hp::DoFHandler<dim, spacedim>; | |||
There was a problem hiding this comment.
Do you need this change? It is not consistent with our regular friend declaration conventions.
There was a problem hiding this comment.
This change was not wanted.
I wonder which namespace was creating the conflict for you
Yes, it is searching in dealii::internal::parallel. I guess I have included the files in an order which triggers this.
peterrum
force-pushed
the
parallel_namespace_problem
branch
2 times, most recently
from
6fb1b45
to
b8b8745
Compare
|
/rebuild |
bangerth
approved these changes
Apr 3, 2020
peterrum
force-pushed
the
parallel_namespace_problem
branch
from
b8b8745
to
2100a2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.