Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Multigrid::set_debug() #9779

Merged
merged 4 commits into from Mar 30, 2020

Conversation

masterleinad
Copy link
Member

Fixes #9768. The function was deprecated in masterleinad@bfc5899.
In the cycles test, the F-cycle was previously printing V-cycle for the last iteration but is now printing F-cycle instead.

(*coarse)(level, solution[level], defect2[level]);
this->signals.coarse_solve(false, level);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had we just forgotten to call all of these signals? They appear to have existed, after all...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I think I only tested it for the V cycle before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we treat the V-cycle in level_v_step separately and only called the signals there.

@bangerth
Copy link
Member

/rebuild

@kronbichler kronbichler merged commit 7516f9e into dealii:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multigrid test failures
4 participants