Fix a bug in mg ghost layer with periodicity and n_levels=1 #9781
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug in the setup of the level subdomain ids in the ghost layer of the multigrid levels: If we have a mesh with one single level (i.e., not refined, and a case where multigrid may not make much sense), we forgot to identify cells behind periodic boundaries as level ghost cells; this makes downstream multigrid data structures to break down.
The fix is to move the code that sets the periodic data structures before we call
dealii/source/distributed/tria.cc
Line 4727 in a0a79b2
Otherwise the code inside this call, namely the one that identifies the appropriate cells and vertices here:
dealii/source/distributed/tria.cc
Lines 3713 to 3739 in a0a79b2
does not include the periodic neighbors for a triangulation immediately after
add_periodicity
.This was not a problem when we refined the mesh, as then the periodicity has already been set.
FYI @nfehn