Pass ExcNoMatch the description directly

[peterrum]

@nfehn has reported that the following program segfaults:

#include <deal.II/base/parameter_handler.h>


using namespace dealii;

int
main(int argc, char ** argv)
{
  try
  {
     unsigned int i = numbers::invalid_unsigned_int;

     ParameterHandler params;
     params.add_parameter("dummy", i);

  }
  catch(std::exception & exc)
  {
    std::cout << exc.what() << std::endl;
  }

}

The function call add_parameter() fails because the variable does not match the pattern (this is wanted in this example). An exception (ExcNoMatch) is thrown, whose content (PatternBase) does not live in the catch-clause:

dealii/include/deal.II/base/patterns.h

Lines 1412 to 1416 in ec03a88

	DeclException2(ExcNoMatch,
	std::string,
	const Patterns::PatternBase *,
	<< "The string " << arg1 << " does not match the pattern \""
	<< arg2->description() << "\"");

I think this is an unwanted behavior, isn't it? With replacing the pattern directly by the string, this problem could be fixed.

@luca-heltai What do you think?

[luca-heltai]

Yes, I agree. Passing const Patterns::PatternBase * should be avoided. Passing directly the description of the pattern would be the correct option.

[luca-heltai]

/rebuild

[masterleinad]

/rebuild