Some major improvements #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobiwankenobi
commented
Jan 24, 2020
flobiwankenobi
commented
- Removed the CocoaPods dependency for iOS because I had some issues with the new CocoaPod Master Repo.
- Added interface for all TypeScript users out there
- Fixed broken detectorSize for Android
- Fixed wrongly calculated aspect ratio for Android
- Removed SecondaryActivity which causes some strange behavior (e.g. switching orientation was starting a new camera stream)
added 5 commits
November 19, 2019 16:12
- camera opened second time when orientation chages - detectorSize wasn't working - aspect ratio was wrong
|
Hey Florian,
Thanks for this massive contribution! These look great, but I don’t have time to verify and check them for issues. Can we get someone else to check through these and verify they’re good and I’d be happy to merge the pull?
Thanks, Forrest
On Fri, Jan 24, 2020 at 9:07 AM, Florian Biebel <notifications@github.com> wrote:
@flobiwankenobi [https://github.com/flobiwankenobi] requested your review on: #27 [#27] Some major improvements.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub [#27] , or unsubscribe [https://github.com/notifications/unsubscribe-auth/AB56E5O6DM6F6P3NFN25BJ3Q7MG53ANCNFSM4KLIOHZQ] .
|
modified method signatures
|
Some great improvements here, but I think there is still an error in the aspectRatio calculation for the CameraSourcePreview. Rotating a device with the preview up, you can see the distortion. The preview is stretched horizontally when the phone is in portrait mode, and stretched vertically when the phone is in landscape. |
added 12 commits
February 17, 2020 08:57
added a textarea for debug info
print left top right bottom
layout adjustment
Gave debugtext a color and adjusted position
color change
Attempting to print selectedPair
min and max in startifready
print size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.