Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password generator stalls when invoked #4

Closed
benjamin-smith opened this issue Jun 23, 2016 · 14 comments
Closed

Password generator stalls when invoked #4

benjamin-smith opened this issue Jun 23, 2016 · 14 comments

Comments

@benjamin-smith
Copy link

benjamin-smith commented Jun 23, 2016

image

Never moves beyond this point. Started seemingly randomly about 2 weeks ago, worked fine before that.

Not familiar with debugging Alfred Workflows, what other info can I provide?

image

Using release v1.3.

@deanishe
Copy link
Owner

Could you provide:

  • Alfred version number
  • Any output in Alfred's debugger

@benjamin-smith
Copy link
Author

Alfred v2.8.5 (439)

Nothing shows in the debugger for any command, see Gif: https://www.dropbox.com/s/c0m2d3eywwdjpig/alfred.gif?dl=0

The debugger is working for other workflows.

@rob-anderson
Copy link

I am also experiencing this problem. Rebooting the entire machine fixes it.

Thanks for this workflow btw - I use it all the time.

@benjamin-smith
Copy link
Author

I've rebooted a few times, with unfortunately no change in behavior.

@rob-anderson
Copy link

This keeps recurring for me.

@deanishe
Copy link
Owner

It might be one of the generators. Which ones do you have turned on?

@benjamin-smith
Copy link
Author

Not sure! The pwconf command also hangs indefinitely...

image

@deanishe
Copy link
Owner

@benjamin-smith Update Alfred and reboot your machine.

There is a known bug in older versions of Alfred 2 that causes workflows to hang.

@benjamin-smith
Copy link
Author

I upgraded to latest version v2.8.6 (441), restarted a couple times – issue still persists. All of my other workflows are working as expected, only this one is hanging. Even pwconf continues to hang.

@peelman
Copy link

peelman commented Mar 14, 2017

yeah...still having this issue, even using the version just released in february and the latest Alfred betas.

Running the scripts from the command line, they never exit. They return data, but just hang at the end.

You end up with a debug line like this when you finally do kill it:

python pwgen.py -d generate 96
12:09:50 workflow.py:2231 DEBUG    Workflow finished in 59.249 seconds.

I got tired of having to manually delete all the update code from the old version (the update python script has been hanging for me for ages upon ages every time a password was gen'd; when the project went into stasis I gave up on an update fixing it but couldn't find an alternative that worked as well, so was easier to just hack it for the time being). Glad I saved a copy of that for the time being...

@peelman
Copy link

peelman commented Mar 14, 2017

I end up with a number of stalled/orphaned processes treed under Alfred.

screen shot 2017-03-14 at 2 00 57 pm

@peelman
Copy link

peelman commented Mar 14, 2017

Couple of notes:

Removing ~/Library/Application Support/Alfred 3/Workflows/net.deanishe.alfred-pwgen fixed my problem. When using pwgen next everything worked as expected.

Looking at the two directories, two things jumped out at me: I had a settings.json.lock file that had apparently been stuck in place since December of 2015.

My settings.json only showed a couple of minor differences:

screen shot 2017-03-14 at 2 11 40 pm

So my guess would be that a bug or crash caused the lock file to not be removed and the lock file being persistently present was causing some issues and the script was not properly timing out or displaying a warning while waiting for the lock to be released, and none of these were problems with the old versions of pwgen I was using / hacking on in order to continue functioning.

So I guess ignore my previous two messages, unless you find this thread while working through similar problems, in which case, go to the aforementioned path and try removing an errant lock file.

@deanishe thanks for your hard work thus far 🥇. My only humble request would be some lock file timestamp checking and/or some timeouts implemented for safety!

@deanishe
Copy link
Owner

some lock file timestamp checking and/or some timeouts implemented for safety!

Will do. Clearly I was planning to do something along these lines, as Alfred-Workflow writes the PID to the lockfile, but I never got round to adding the code to read and check it 😔

@deanishe
Copy link
Owner

deanishe commented Apr 1, 2017

Hopefully fixed the hanging in v2.0.2 by updating Alfred-Workflow.

@deanishe deanishe closed this as completed Apr 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants