Issue2 ops browser #15
Conversation
|
Will keep open a little longer - awaiting fix to "selective visibility" issue: #11 |
|
Note: on Linux, I needed to install webkit for in-place browser control to work, as recorded here: |
| @@ -1,20 +1,20 @@ | |||
| package samplemodel; | |||
There was a problem hiding this comment.
Hmm, I can't see what changed in this file. If it was just whitespace due to reformatting, it may have been better to "discard" the changes. Happy to talk this through further with you, if you want.
|
Yes - I think you've got the UI right in this new flow. We only show the child permutations if the operation is available, and we show the fail message against the operation. Whilst swimming I'd decided that seemed the best solution - great! |
|
I did some refactoring to cleanup the operation builders. Now the SampleModelOperationRegistry is only responsible to read the extensions (plugin.xml). The buildLibrary method and all related logic (isApplicable, getInputPermutations) is located in a base builder class OperationsLibraryBuilder, with two subclasses for the tree and menu. I think this looks simpler, but let me know if there could still be improvements. |
Accumulated changes for the operations browser