Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability issue in Tree vs Node for ops that have children #17

Closed
IanMayo opened this issue Apr 22, 2016 · 3 comments
Closed

Usability issue in Tree vs Node for ops that have children #17

IanMayo opened this issue Apr 22, 2016 · 3 comments
Assignees

Comments

@IanMayo
Copy link
Member

IanMayo commented Apr 22, 2016

IMHO we have an issue with how we display the subtract operation.

Here we have it with two numbers selected:
tree

And here with three numbers selected:
leaf

In my opinion it's right to show "Subtract" as a tree/folder - whether there are applicable child operations, or not. It should be consistent across the two.

Hmm, maybe not the same folder as for "Sublibrary sample". That folder is clearly for organising child operations. I can work with my designer to come up with a new tree icon for an operation that contains children. Temporarily, could you use another standard Eclipse icon for these "Operations with permutations" objects?

@dinkoivanov
Copy link
Contributor

The standard Eclipse project icon was used for non-commutative operations, while the Eclipse folder icon remained for the libraries & sublibraries:
capture0
Even without children same icon is used (disabled here):
capture

@IanMayo
Copy link
Member Author

IanMayo commented Apr 26, 2016

Those icons look great, thanks.

@IanMayo
Copy link
Member Author

IanMayo commented Apr 26, 2016

Fixed in 18bc3a9

@IanMayo IanMayo closed this as completed Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants