feat: add CSX patching #1282
Merged
feat: add CSX patching #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mostly just worked, but there were a few details: * Strings needed their own case, since CSX allows interpolated strings that aren't surrounded in curly braces, so we need to sometimes add curly braces. * For some reason `<div /> arg` (a function call) works and there's a test for it, but introducing the implicit parens causes a syntax error. To make it not a syntax error, I wrap the LHS in parens in that one case. * I had to upgrade esnext in order to support fragment syntax. This ended up breaking some optional chaining forms that are no longer supported in the latest proposal, so I disabled those tests. I also fixed a TypeScript warning in update-website.ts that I ran into when trying TypeScript configurations.
|
🎉 This PR is included in version 4.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hneiva
pushed a commit
to hneiva/decaffeinate
that referenced
this pull request
May 10, 2019
This mostly just worked, but there were a few details: * Strings needed their own case, since CSX allows interpolated strings that aren't surrounded in curly braces, so we need to sometimes add curly braces. * For some reason `<div /> arg` (a function call) works and there's a test for it, but introducing the implicit parens causes a syntax error. To make it not a syntax error, I wrap the LHS in parens in that one case. * I had to upgrade esnext in order to support fragment syntax. This ended up breaking some optional chaining forms that are no longer supported in the latest proposal, so I disabled those tests. I also fixed a TypeScript warning in update-website.ts that I ran into when trying TypeScript configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly just worked, but there were a few details:
aren't surrounded in curly braces, so we need to sometimes add curly braces.
<div /> arg(a function call) works and there's a test forit, but introducing the implicit parens causes a syntax error. To make it not
a syntax error, I wrap the LHS in parens in that one case.
breaking some optional chaining forms that are no longer supported in the
latest proposal, so I disabled those tests.
I also fixed a TypeScript warning in update-website.ts that I ran into when
trying TypeScript configurations.