Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs needed #154

Open
Specbee-onchain opened this issue Apr 29, 2021 · 8 comments
Open

docs needed #154

Specbee-onchain opened this issue Apr 29, 2021 · 8 comments

Comments

@Specbee-onchain
Copy link

No description provided.

@nachomazzara
Copy link
Collaborator

Hi! thanks for opening an issue. What kind of docs do you think will be useful?

@Specbee-onchain
Copy link
Author

Would be cool to cover LAND parcel distribution. I see you have a set of scripts used for deployment. It would be suitable for newcomers to write a document covering LAND deployment on the chain with one minimal example. I can take the task, just guide me a bit :)

@Specbee-onchain
Copy link
Author

I can open a PR with a document as I see it should be, you can correct me then if I am wrong. It is possible to do in the wiki section too, need to create wiki though

@nachomazzara
Copy link
Collaborator

nachomazzara commented Apr 29, 2021

Create it with markdown here if you want. It Will be easier to review

@Specbee-onchain
Copy link
Author

Specbee-onchain commented Apr 30, 2021

  1. Deploy the fully compiled land registry. Initialize with the value of "0x"

  2. Deploy Estate Registry with Name, Symbol, and Land Registry contract address (proxy address if you use one) as the parameters. Also, use setLANDRegistry to assign LandRegistry contract to the EstateRegistry.

  3. Deploy 2 Proxies for Land and Estate registries. Use setEstateRegistry in LANDRegistry contract to assign EstateRegistry contract address initially

  4. For minting new LAND parcels use: assignMultipleParcels with 2 arrays of XY coordinates and owner address.

  5. Try transferring your LAND ERC-721 tokens to another wallet using transferManyLand. Make sure to add them to your Metamask as custom tokens.

I am sure I can write a script for this repository to deploy and set up all contracts at once using truffle, I think it is better to do via a script since there is LAND Terraform Sale contract involved for the original LAND distribution, etc.

I am still not sure how the original map of Decentraland was formed, I understand that you initially created a grid of XY -150,-150 to 150, 150 from some genesis.json and started auctioning those Parcels and then assigned Roads/Genesis Plazas. Is it something close to that? I can write a setup script for all of that across multiple repositories. Much appreciated :)

@nachomazzara
Copy link
Collaborator

nachomazzara commented Apr 30, 2021

Do you want to create a PR with it? That would be really helpful.

In my last comment with here I meant to here at Github by creating a PR, sorry.

@Specbee-onchain
Copy link
Author

Specbee-onchain commented Apr 30, 2021

Okay, I can do that. I will write a truffle script in migrations to set up all at once. Let me test it all on ropsten. PR will be there today

@Specbee-onchain
Copy link
Author

I am on #153 for now, docs PR will be added shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants