Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add update operator for all #141

Merged
merged 10 commits into from Apr 23, 2019

Conversation

Projects
None yet
3 participants
@nachomazzara
Copy link
Collaborator

commented Apr 17, 2019

  • Add UpdateOperatorForAll for LAND and Estate registry smart contracts

Interface:

setUpdateManager(address _owner, address _operator, bool _approved)

event UpdateManager(
    address indexed _owner,
    address indexed _operator,
    address indexed _caller,
    bool _approved
); 

nachomazzara added some commits Apr 17, 2019

eordano and others added some commits Apr 17, 2019

Feat/update for all nit (#142)
* chore: clean whitespace at end of lines

* nit: || operators at the beginning of lines

Signed-off-by: Esteban Ordano <esteban@decentraland.org>
@abarmat
Copy link
Member

left a comment

Looks good

nachomazzara added some commits Apr 22, 2019

@@ -39,6 +39,15 @@ contract EstateRegistry is Migratable, IEstateRegistry, ERC721Token, ERC721Recei
_;
}

modifier onlyManager(uint256 estateId) {

This comment has been minimized.

Copy link
@eordano

eordano Apr 22, 2019

Member

canManageOperators?

This comment has been minimized.

Copy link
@nachomazzara

nachomazzara Apr 22, 2019

Author Collaborator

Hmm idk. It involves also to update content. I thought canManage but is super generic

This comment has been minimized.

Copy link
@eordano

eordano Apr 23, 2019

Member

"OnlyManager" can be interpreted as "not the owner, not the operator, only the manager".

This comment has been minimized.

Copy link
@eordano

eordano Apr 23, 2019

Member

canSetUpdateOperator

@eordano
Copy link
Member

left a comment

other than the minor nit on "canManage", this is good to go

@nachomazzara

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 23, 2019

@eordano ready to merge

@nachomazzara nachomazzara force-pushed the feat/add-updateOperatorForAll branch from 9215438 to 4a73f7a Apr 23, 2019

@eordano

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

circleci está de vacas

@eordano eordano merged commit 210ef0a into master Apr 23, 2019

1 check passed

security/pgp-check Verified Ignacio Mazzara <nacho@decentraland.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.