feat: Add the new FIAT Flow to the ClaimName feature #2102

juanmahidalgo · 2024-01-12T09:45:10Z

FF not enabled

FF enabled

coveralls · 2024-01-15T12:13:30Z

coverage: 67.252% (+0.003%) from 67.249%
when pulling 08cf588 on feat/ens-with-wert
into b40c3b9 on master.

LautaroPetaccio

Nice work! It looks great. I've left some minor comments.
There's an issue that I've encountered wile trying the FIAT option:

payload:  {error: 'No identity found'}
type:  "[Failure] Open FIAT Gateway Widget"

There might be an issue with the retrieval of the identity in the decentraland-dapps repo.

LautaroPetaccio · 2024-01-22T14:55:47Z

webapp/src/modules/translation/locales/en.json

@@ -1626,7 +1642,7 @@
    }
  },
  "set_name_as_alias_modal": {
-    "title": "Use NAME as Alias",
+    "title": "Use NAME as Username",


This change was done only in the english language, should we replicate it in the other languages?

LautaroPetaccio · 2024-01-22T14:57:09Z

webapp/src/modules/translation/locales/es.json

    "claim_name_fat_finger_modal": {
      "title": "Por favor confirmar tu nombre",
-      "description": "Eelegiste {name}. Entra nuevamente el nombre para confirmar tu selección.",
+      "description": "Eelegiste {name}. {br} Entra nuevamente el nombre para confirmar tu selección.",


Just a small typo:

Suggested change

"description": "Eelegiste {name}. {br} Entra nuevamente el nombre para confirmar tu selección.",

"description": "Elegiste {name}. {br} Entra nuevamente el nombre para confirmar tu selección.",

LautaroPetaccio · 2024-01-22T14:58:11Z

webapp/src/config/env/stg.json

@@ -45,5 +45,6 @@
  "SENTRY_DSN": "https://1dc401149e1c819b8477565c9cdd9b70@o4504361728212992.ingest.sentry.io/4505743351676928",
  "SQUID_API_URL": "https://v2.api.squidrouter.com",
  "DCL_LISTS_SERVER": "https://dcl-lists.decentraland.today",
-  "AUTH_URL": "/auth"
+  "AUTH_URL": "/auth",
+  "WERT_URL": "https://sandbox.wert.io"


Should we use the production URL in stg?

LautaroPetaccio · 2024-01-22T14:59:28Z

webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.css

+  border-radius: 6px;
+  border: 1px solid #43404a;
+  margin-bottom: 11px;
+  /* border-radius: 14px; */


Would you mind removing this comment?

LautaroPetaccio · 2024-01-22T15:04:10Z

webapp/src/modules/features/selectors.ts

@@ -228,3 +228,14 @@ export const getIsAuthDappEnabled = (state: RootState) => {
  }
  return false
 }
+
+export const getIsClaimingNamesWithFiatEnabled = (state: RootState) => {


Would you mind adding this FF to the FF tests?

LautaroPetaccio · 2024-01-22T15:11:37Z

webapp/src/modules/translation/locales/en.json

+          "name": "FIAT",
+          "new": "new",
+          "title": "Using Debit and Credit Cards",
+          "subtitle": "Price rate changes may change"


Should this be?:

Suggested change

"subtitle": "Price rate changes may change"

"subtitle": "Price rates may change"

webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.tsx

LautaroPetaccio · 2024-01-22T17:48:27Z

webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.tsx

+  }, [wallet, ENSName, analytics, onOpenFiatGateway, onClaimTxSubmitted])
+
+  const handleClaimWithCardClick = useCallback(() => {
+    return isClaimingNamesWithFiatEnabled


What do you think about not doing anything when the claiming process (both for FIAT and Crypto) has started? It's possible to change the options while waiting for the transaction to be completed.

webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.spec.tsx

LautaroPetaccio · 2024-01-22T18:05:52Z

webapp/src/modules/ens/sagas.ts

+
+    const from = address
+
+    try {


Would you mind adding tests for this new handler?

LautaroPetaccio · 2024-01-23T17:42:32Z

webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.tsx

    }
+  }, [wallet, ENSName, analytics, onOpenFiatGateway, onClaimTxSubmitted])
+
+  const isLoading = useMemo(() => isClaiming || isLoadingFIATWidget, [])


If I'm not wrong, as there's no dependencies in this useMemo, isLoading will be computed only once. As this is a boolean comparison, what do you think about removing the useMemo hook?

Suggested change

const isLoading = useMemo(() => isClaiming || isLoadingFIATWidget, [])

const isLoading = isClaiming || isLoadingFIATWidget

webapp/src/components/Modals/ClaimNameFatFingerModal/ClaimNameFatFingerModal.spec.tsx

vercel · 2024-01-23T18:05:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
marketplace	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 25, 2024 2:55pm

…2111) * feat: add workaround to show the ENS on its way before being minted * test: add tests in SuccessPage for the ens new case

LautaroPetaccio

🚀

vercel bot deployed to Preview January 12, 2024 10:11 View deployment

vercel bot deployed to Preview January 15, 2024 12:13 View deployment

vercel bot deployed to Preview January 15, 2024 13:33 View deployment

vercel bot deployed to Preview January 15, 2024 14:36 View deployment

vercel bot deployed to Preview January 15, 2024 15:50 View deployment

vercel bot deployed to Preview January 15, 2024 16:06 View deployment

vercel bot deployed to Preview January 15, 2024 16:56 View deployment

vercel bot deployed to Preview January 16, 2024 16:20 View deployment

vercel bot deployed to Preview January 16, 2024 17:42 View deployment

vercel bot deployed to Preview January 17, 2024 11:20 View deployment

vercel bot deployed to Preview January 17, 2024 11:40 View deployment

vercel bot deployed to Preview January 17, 2024 14:34 View deployment

vercel bot deployed to Preview January 17, 2024 15:07 View deployment

juanmahidalgo force-pushed the feat/ens-with-wert branch from 40e531a to 8cb95bc Compare January 18, 2024 12:25

vercel bot had a problem deploying to Preview January 18, 2024 12:27 Failure

vercel bot had a problem deploying to Preview January 22, 2024 11:35 Failure

vercel bot had a problem deploying to Preview January 22, 2024 11:58 Failure

juanmahidalgo force-pushed the feat/ens-with-wert branch from 43de1e0 to 76a05dd Compare January 22, 2024 12:01

vercel bot had a problem deploying to Preview January 22, 2024 12:01 Failure

vercel bot deployed to Preview January 22, 2024 12:22 View deployment

LautaroPetaccio reviewed Jan 22, 2024

View reviewed changes

vercel bot deployed to Preview January 23, 2024 16:25 View deployment

vercel bot deployed to Preview January 23, 2024 16:37 View deployment

LautaroPetaccio approved these changes Jan 23, 2024

View reviewed changes

vercel bot deployed to Preview January 23, 2024 18:11 View deployment

juanmahidalgo added 3 commits January 24, 2024 16:09

feat: Add the new FIAT Flow to the ClaimName feature

2603ebc

feat: add logic to listen for wert tx

2b200ae

feat: add wert sepolia logic

0397958

juanmahidalgo added 17 commits January 24, 2024 16:09

feat: add the zone URL for the marketplace-server

9439079

feat: add label and icons

d4a88a3

feat: add fixed width to the claim name page

05cc6fb

feat: adjust styling

25bc1ce

feat: update balance check logic

04b5d3b

feat: add Enter handler and focus fat finger input on opening it

2a4c726

feat: use hardcoded value for the wert contract

7f80ab6

feat: add Names FIAT payments FF and tests

9a83ce0

feat: add loading status for both fiat and crypto confirm buttons

88817db

feat: add tracking for the 2 main events

474ef07

feat: add missing translations

e15bcaa

feat: use latest dcl dapps lib to trigger the wert widget

3c54ea4

feat: remove all wert logic since its wrapped in dcl dapps now

8137a28

feat: remove old code from ClaimNamePage

cfea67e

feat: add some tests for new sagas handlers

907c9f4

feat: add new identity saga

481db7e

fix: fix bug missing deps in useMemo

64e9733

juanmahidalgo force-pushed the feat/ens-with-wert branch from f8a7148 to 64e9733 Compare January 24, 2024 15:09

vercel bot deployed to Preview January 24, 2024 15:11 View deployment

vercel bot had a problem deploying to Preview January 25, 2024 08:52 Failure

juanmahidalgo force-pushed the feat/ens-with-wert branch from cb82989 to 64e9733 Compare January 25, 2024 11:48

feat: add workaround to show the ENS on its way before being minted (#…

dd7b124

…2111) * feat: add workaround to show the ENS on its way before being minted * test: add tests in SuccessPage for the ens new case

vercel bot deployed to Preview January 25, 2024 14:32 View deployment

feat: bump libs and change the track to the onSuccess handler

08cf588

vercel bot deployed to Preview January 25, 2024 14:55 View deployment

LautaroPetaccio approved these changes Jan 25, 2024

View reviewed changes

juanmahidalgo merged commit 74409e1 into master Jan 25, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add the new FIAT Flow to the ClaimName feature #2102

feat: Add the new FIAT Flow to the ClaimName feature #2102

juanmahidalgo commented Jan 12, 2024 •

edited

Loading

coveralls commented Jan 15, 2024 •

edited

Loading

LautaroPetaccio left a comment

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 22, 2024

LautaroPetaccio Jan 23, 2024

vercel bot commented Jan 23, 2024 •

edited

Loading

LautaroPetaccio left a comment

	"description": "Eelegiste {name}. {br} Entra nuevamente el nombre para confirmar tu selección.",
	"description": "Elegiste {name}. {br} Entra nuevamente el nombre para confirmar tu selección.",

	"subtitle": "Price rate changes may change"
	"subtitle": "Price rates may change"

	const isLoading = useMemo(() => isClaiming \|\| isLoadingFIATWidget, [])
	const isLoading = isClaiming \|\| isLoadingFIATWidget

feat: Add the new FIAT Flow to the ClaimName feature #2102

feat: Add the new FIAT Flow to the ClaimName feature #2102

Conversation

juanmahidalgo commented Jan 12, 2024 • edited Loading

FF not enabled

FF enabled

coveralls commented Jan 15, 2024 • edited Loading

LautaroPetaccio left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Jan 23, 2024 • edited Loading

LautaroPetaccio left a comment

Choose a reason for hiding this comment

juanmahidalgo commented Jan 12, 2024 •

edited

Loading

coveralls commented Jan 15, 2024 •

edited

Loading

vercel bot commented Jan 23, 2024 •

edited

Loading