fix: add timeout when MM active method hangs #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
webapp/src/modules/wallet/utils.ts
Outdated
| })) as { success: ConnectWalletSuccessAction; failure: ConnectWalletFailureAction } | ||
| failure: take(CONNECT_WALLET_FAILURE), | ||
| timeout: delay(WAIT_FOR_WALLET_CONNECTION_TIMEOUT) // 10 seconds timeout | ||
| })) as { success: ConnectWalletSuccessAction; failure: ConnectWalletFailureAction; timeout: any } |
There was a problem hiding this comment.
Would you mind typing the return of delay? We don't have the linter rule available for it yet, but typing it would help on the changes we need to do:
Suggested change
| })) as { success: ConnectWalletSuccessAction; failure: ConnectWalletFailureAction; timeout: any } | |
| })) as { success: ConnectWalletSuccessAction; failure: ConnectWalletFailureAction; timeout: undefined } |
If I'm not wrong, it should return undefined
webapp/src/modules/wallet/utils.ts
Outdated
| failure: take(CONNECT_WALLET_FAILURE), | ||
| timeout: delay(WAIT_FOR_WALLET_CONNECTION_TIMEOUT) // 10 seconds timeout | ||
| })) as { success: ConnectWalletSuccessAction; failure: ConnectWalletFailureAction; timeout: any } | ||
| console.log('timeout: ', timeout) |
There was a problem hiding this comment.
Would you mind removing the console log?
| it('should finish waiting after the timeout', () => { | ||
| return expectSaga(waitForWalletConnectionAndIdentityIfConnecting) | ||
| .provide([[select(isConnecting), true]]) | ||
| .delay(10000) // Simulate a delay longer than the timeout |
There was a problem hiding this comment.
This should make the test take at least 10 seconds. What if we mock in the provide the delay so it executes instantly?
LautaroPetaccio
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MM is blocked, this saga keeps waiting for ever since it won't succed or failed. This PR adds a timeout to avoid that