Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Styles in the Wearables, Emotes and Items detail page #2248

Merged
merged 1 commit into from
May 13, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

This PR has multiple fixes of the Wearables, Emotes and Items detail pages:

  • It fixes the AssetImage in the Wearables, Emotes and Item details pages, which had a big margin when they had a listing available and where viewed by the owner.
  • It fixes how the owner, collections, description and utils is organized, making them have a table shaped style.
  • It fixes the listing table in the Wearables and Emotes detail pages, which had a button of a bigger size that what they could fit.
  • It fixes the AssetPage padding in mobile devices, which added a big blank space at the top.

Screenshot 2024-05-13 at 09 19 29

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marketplace ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 3:18pm

Copy link

sentry-io bot commented May 13, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: webapp/src/components/AssetPage/ItemDetail/ItemDetail.tsx

Function Unhandled Issue
ItemDetail ReferenceError: nft is not defined ItemDetail(src...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@coveralls
Copy link

Coverage Status

coverage: 66.747% (-0.1%) from 66.854%
when pulling f8b9880 on fix/wearable-emotes-styling
into 5596e6d on master.

@LautaroPetaccio LautaroPetaccio merged commit e64f26f into master May 13, 2024
9 checks passed
@LautaroPetaccio LautaroPetaccio deleted the fix/wearable-emotes-styling branch May 13, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants