Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIP 2 - Eliminate Base64URL Storage Bloat #781

Closed
OR13 opened this issue Jun 30, 2020 · 2 comments
Closed

SIP 2 - Eliminate Base64URL Storage Bloat #781

OR13 opened this issue Jun 30, 2020 · 2 comments
Labels
Spec v0.1.1
Projects
Reference implementation

Comments

@OR13
Copy link
Contributor

OR13 commented Jun 30, 2020 •
edited 

  SIP: 2
  Upgrade-Type: Hard Fork (to guarantee outcomes)
  Title: Eliminate Base64URL Storage Bloat
  Author: Orie Steele <orie@transmute.industries>
  Comments-Summary: No comments yet.
  Comments-URI: https://github.com/decentralized-identity/sidetree/sips/2.md
  Status: Draft
  Created: 2020-06-30

Summary

Base64URL is used throughout sidetree, in many cases, as a substitute for canonicalization...

Motivation

"Although Base64 is a relatively efficient way of encoding binary data it will, on average still increase the file size for more than 25%."

Requirements

Data structure file size should be minimized.

Technical Proposal

Replace Base64URL with JCS.
@OR13 OR13 self-assigned this Jun 30, 2020
@OR13
Copy link
Contributor Author

OR13 commented Jun 30, 2020

Granted, I wrote these tests in 10 minutes... https://github.com/OR13/jcs-vs-base64url

I welcome a counter proposal on the performance / storage side of this debate.

@OR13 OR13 mentioned this issue Jun 30, 2020
Closed
@OR13 OR13 mentioned this issue Jul 14, 2020
Closed
isaacJChen added a commit that referenced this issue Sep 21, 2020
@isaacJChen
feat(ref-imp): #781 - make long form use jcs
8eba485
isaacJChen added a commit that referenced this issue Sep 21, 2020
@isaacJChen
feat(ref-imp): #781 - make long form use jcs
3d218d4
isaacJChen added a commit that referenced this issue Sep 21, 2020
@isaacJChen
feat(ref-imp): #781 - add some tests
6662e9f
isaacJChen added a commit that referenced this issue Sep 21, 2020
@isaacJChen
feat(ref-imp): #781 - add more tests
d10ac4a
isaacJChen added a commit that referenced this issue Sep 22, 2020
@isaacJChen
feat(ref-imp): #781 - add even more tests
6921d8b
isaacJChen added a commit that referenced this issue Sep 22, 2020
@isaacJChen
feat(ref-imp): #781 - add expected document
c690412
isaacJChen added a commit that referenced this issue Sep 22, 2020
@isaacJChen
feat(ref-imp): #781 - lint
2f73838
isaacJChen added a commit that referenced this issue Sep 22, 2020
@isaacJChen
feat(ref-imp): #781 - fix test net did parsing
9920999
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
82d087c
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - lint
7c1bc51
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - test
896a808
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - add anchor file mode
d964c92
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - lint
0e2665d
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - make long form use jcs SIP2 (#864)
5808eaf
isaacJChen added a commit that referenced this issue Sep 23, 2020
@isaacJChen
feat(ref-imp): #781 - make jcs long form do size check on delta
f71108c
isaacJChen added a commit that referenced this issue Sep 24, 2020
@isaacJChen
feat(ref-imp): #781 - minor changes
a0ba896
isaacJChen added a commit that referenced this issue Sep 25, 2020
@isaacJChen
feat(ref-imp): #781 - lint
92ef1e2
isaacJChen added a commit that referenced this issue Sep 25, 2020
@isaacJChen
feat(ref-imp): #781 - change protocol param
2f4186a
isaacJChen added a commit that referenced this issue Sep 25, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comment
fccff8d
isaacJChen added a commit that referenced this issue Sep 25, 2020
@isaacJChen
feat(ref-imp): #781 - make jcs long form do size check on delta (#866)
20cfc61
@thehenrytsai thehenrytsai added this to 2020 October in Reference implementation Oct 2, 2020
@OR13 OR13 removed their assignment Oct 7, 2020
isaacJChen added a commit that referenced this issue Oct 8, 2020
@isaacJChen
feat(ref-imp): #781 - make rest api json for SIP2
8af58e1
isaacJChen added a commit that referenced this issue Oct 8, 2020
@isaacJChen
feat(ref-imp): #781 - make chunk file json for SIP2
66b1b9d
isaacJChen added a commit that referenced this issue Oct 8, 2020
@isaacJChen
feat(ref-imp): #781 - sort import
bf067f1
isaacJChen added a commit that referenced this issue Oct 9, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
072d436
isaacJChen added a commit that referenced this issue Oct 9, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
9059aa7
isaacJChen added a commit that referenced this issue Oct 10, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
bbd40df
isaacJChen added a commit that referenced this issue Oct 10, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
638d696
isaacJChen added a commit that referenced this issue Oct 10, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
c9592bc
isaacJChen added a commit that referenced this issue Oct 10, 2020
@isaacJChen
feat(ref-imp): #781 - address pr comments
c212d13
isaacJChen added a commit that referenced this issue Oct 10, 2020
@isaacJChen
Ische/sip2 #781
8c59559
@sandrask sandrask mentioned this issue Oct 15, 2020
Closed
@thehenrytsai
Copy link
Collaborator

Done.

Reference implementation automation moved this from 2020 October to Done Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Spec v0.1.1
Projects
No open projects
Reference implementation
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OR13 @thehenrytsai